Bug 230724

Summary: [LFC][IFC] InlineLevelBox only needs a handful of style properties
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2021-09-23 15:18:28 PDT
ssia
Attachments
Patch (14.31 KB, patch)
2021-09-23 15:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.68 KB, patch)
2021-09-23 19:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-09-23 15:21:09 PDT
Created attachment 439098 [details] Patch
alan
Comment 2 2021-09-23 19:58:17 PDT
Created attachment 439118 [details] Patch
Antti Koivisto
Comment 3 2021-09-24 06:07:40 PDT
Comment on attachment 439118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439118&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:133 > + struct Style { > + const FontMetrics& primaryFontMetrics; > + const Length& lineHeight; > + InlineLayoutUnit primaryFontSize { 0 }; > + VerticalAlignment verticalAlignment { }; > + }; > + Style m_style; Nice
EWS
Comment 4 2021-09-24 07:39:11 PDT
Committed r283042 (242102@main): <https://commits.webkit.org/242102@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439118 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-24 07:40:21 PDT
<rdar://problem/83495963>
Note You need to log in before you can comment on or make changes to this bug.