| Summary: | Stop using ALWAYS_LOG in media related classes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | don.olmstead, eric.carlson, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Basuke Suzuki
2021-09-23 14:57:14 PDT
From talking to Eric Carlson it sounds like we'd want to look to see if this is specific to our implementation. `ALWAYS_LOG` should only be used for methods that are called periodically, while `DEBUG_LOG` is for methods that are called frequently. (In reply to Basuke Suzuki from comment #0) > There are hundreds of logs per seconds while playing video. It's just too much. This shouldn't be true, and definitely isn't the case in Apple's ports. `ALWAYS_LOG` is only supposed to be used in methods that are not called that frequently. What methods are being logged hundreds of times per second? (In reply to Eric Carlson from comment #2) > (In reply to Basuke Suzuki from comment #0) > > There are hundreds of logs per seconds while playing video. It's just too much. > > This shouldn't be true, and definitely isn't the case in Apple's ports. > > `ALWAYS_LOG` is only supposed to be used in methods that are not called that > frequently. What methods are being logged hundreds of times per second? Really? Thanks for the info. I need double check my investigation. I'll let you know what I find then. |