Bug 230681

Summary: Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendants() instead of pointer-events check
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635, 229330    
Attachments:
Description Flags
Patch none

Description Tim Nguyen (:ntim) 2021-09-23 02:12:29 PDT
visibleToHitTesting() will account for inert as well.
Comment 1 Tim Nguyen (:ntim) 2021-09-23 02:17:30 PDT
Created attachment 439028 [details]
Patch
Comment 2 Antti Koivisto 2021-09-23 03:31:25 PDT
Comment on attachment 439028 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439028&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1593
> -        bool userInteractive = renderer().style().pointerEvents() != PointerEvents::None;
> +        bool userInteractive = renderer().visibleToHitTesting();

This also adds visibility test but I guess that is fine.
Comment 3 EWS 2021-09-23 04:55:34 PDT
Committed r282957 (242047@main): <https://commits.webkit.org/242047@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439028 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-23 04:56:42 PDT
<rdar://problem/83442427>