Bug 230681 - Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendants() instead of pointer-events check
Summary: Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendants() ins...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
Keywords: InRadar
Depends on:
Blocks: dialog-element 229330
  Show dependency treegraph
Reported: 2021-09-23 02:12 PDT by Tim Nguyen (:ntim)
Modified: 2021-09-23 04:56 PDT (History)
12 users (show)

See Also:

Patch (1.73 KB, patch)
2021-09-23 02:17 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-09-23 02:12:29 PDT
visibleToHitTesting() will account for inert as well.
Comment 1 Tim Nguyen (:ntim) 2021-09-23 02:17:30 PDT
Created attachment 439028 [details]
Comment 2 Antti Koivisto 2021-09-23 03:31:25 PDT
Comment on attachment 439028 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=439028&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:1593
> -        bool userInteractive = renderer().style().pointerEvents() != PointerEvents::None;
> +        bool userInteractive = renderer().visibleToHitTesting();

This also adds visibility test but I guess that is fine.
Comment 3 EWS 2021-09-23 04:55:34 PDT
Committed r282957 (242047@main): <https://commits.webkit.org/242047@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439028 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-23 04:56:42 PDT