Bug 230678

Summary: Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()`
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Web InspectorAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, joepeck, koivisto, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635, 229330    
Attachments:
Description Flags
Patch none

Tim Nguyen (:ntim)
Reported 2021-09-23 01:44:13 PDT
The definition of isHidden is: bool isHidden() const override { return isAXHidden() || isDOMHidden(); } So it's effectively the same thing. I'm doing this refactoring so I can factor in inert once I split it out from isAXHidden().
Attachments
Patch (2.85 KB, patch)
2021-09-23 01:49 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-09-23 01:49:07 PDT
Created attachment 439025 [details] Patch
EWS
Comment 2 2021-09-23 04:50:48 PDT
Committed r282955 (242045@main): <https://commits.webkit.org/242045@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439025 [details].
Radar WebKit Bug Importer
Comment 3 2021-09-23 04:51:37 PDT
<rdar://problem/83442291>
Note You need to log in before you can comment on or make changes to this bug.