Bug 230678 - Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()`
Summary: Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: dialog-element 229330
  Show dependency tree / graph
 
Reported: 2021-09-23 01:44 PDT by Tim Nguyen (:ntim)
Modified: 2021-09-23 04:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.85 KB, patch)
2021-09-23 01:49 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-09-23 01:44:13 PDT 
The definition of isHidden is:

bool isHidden() const override { return isAXHidden() || isDOMHidden(); }

So it's effectively the same thing. I'm doing this refactoring so I can factor in inert once I split it out from isAXHidden().
Comment 1 Tim Nguyen (:ntim) 2021-09-23 01:49:07 PDT 
Created attachment 439025 [details]
Patch
Comment 2 EWS 2021-09-23 04:50:48 PDT 
Committed r282955 (242045@main): <https://commits.webkit.org/242045@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439025 [details].
Comment 3 Radar WebKit Bug Importer 2021-09-23 04:51:37 PDT 
<rdar://problem/83442291>