| Summary: | Unify more media-related WebCore source files | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, mmaxfield, philipj, sergio, simon.fraser, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-09-22 21:34:12 PDT
Created attachment 439011 [details]
Patch
Comment on attachment 439011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439011&action=review > Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:-52 > -static const NSString *PlaybackSessionIdKey = @"PlaybackSessionID"; IIRC one of the other common semi-hacky answers was to stick (part of) the filename in it somewhere. Ideally of course it would come from some other file to avoid this problem... > Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:162 > -static bool isEqual(Uint8Array* data, const char* literal) > +static bool isEqual2(Uint8Array* data, const char* literal) Ditto the "maybe file name or some other context instead of weird suffixes" Tools/Scripts/svn-apply failed to apply attachment 439011 [details] to trunk.
Please resolve the conflicts and upload a new patch.
|