Bug 230642

Summary: Turn WebCore::LineCap and WebCore::LineJoin into 8-bit enum classes
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, pdr, sabouhallawa, schenney, sergio, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
For EWS
none
For EWS none

Description Wenson Hsieh 2021-09-22 14:37:09 PDT 
Some self-contained refactoring, en route to larger changes around the concurrent display list processing model.
Comment 1 Wenson Hsieh 2021-09-22 16:09:45 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-09-22 16:30:05 PDT 
Created attachment 438990 [details]
For EWS
Comment 3 Simon Fraser (smfr) 2021-09-22 17:44:59 PDT 
Comment on attachment 438990 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=438990&action=review

> Source/WebCore/platform/graphics/GraphicsTypes.h:93
>      ButtCap,
>      RoundCap,
>      SquareCap

Butt, Round, Square

> Source/WebCore/platform/graphics/GraphicsTypes.h:99
>      MiterJoin,
>      RoundJoin,
>      BevelJoin

Miter, Round, Bevel.
Comment 4 Wenson Hsieh 2021-09-22 17:56:40 PDT 
Comment on attachment 438990 [details]
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=438990&action=review

Thanks for the review.

>> Source/WebCore/platform/graphics/GraphicsTypes.h:93
>>      SquareCap
> 
> Butt, Round, Square

Fixed!

>> Source/WebCore/platform/graphics/GraphicsTypes.h:99
>>      BevelJoin
> 
> Miter, Round, Bevel.

👍🏻
Comment 5 Wenson Hsieh 2021-09-22 18:48:53 PDT 
Created attachment 439003 [details]
For EWS
Comment 6 EWS 2021-09-22 21:30:57 PDT 
Committed r282920 (242034@main): <https://commits.webkit.org/242034@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439003 [details].
Comment 7 Radar WebKit Bug Importer 2021-09-22 21:32:15 PDT 
<rdar://problem/83431075>