Bug 230631

Summary: Add checkScriptSyntax function to jsc host environment
Product: WebKit Reporter: Rick Waldron <rwaldron>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Rick Waldron 2021-09-22 10:00:25 PDT 
In jsc.cpp, there is currently checkSyntax() and checkModuleSyntax(). The former expects and filename, while the latter expects a string of javascript code. This would introduce a function called checkScriptSyntax() that performed the same operation as checkModuleSyntax(), without the module specific semantics.
Comment 1 Rick Waldron 2021-09-24 09:06:55 PDT 
Created attachment 439153 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-24 11:29:40 PDT 
Comment on attachment 439153 [details]
Patch

r=me
Comment 3 EWS 2021-09-24 11:30:39 PDT 
? found in /Volumes/Data/worker/Commit-Queue/build/JSTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 4 Yusuke Suzuki 2021-09-24 11:34:08 PDT 
Comment on attachment 439153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439153&action=review

Setting r- since ChangeLog file is not correct.

> Source/JavaScriptCore/ChangeLog:6
> +        Reviewed by ?.

Default line is necessary for commit-queue. https://webkit.org/contributing-code/#changelog-files
You can check the instructions of contribution in https://webkit.org/contributing-code/ :)
Comment 5 Rick Waldron 2021-09-24 11:39:47 PDT 
I didn't know if I should put a name before I got the actual review ;)
Comment 6 Rick Waldron 2021-09-24 11:40:52 PDT 
Created attachment 439176 [details]
Patch
Comment 7 Rick Waldron 2021-09-24 11:45:56 PDT 
Created attachment 439178 [details]
Patch
Comment 8 EWS 2021-09-24 15:13:11 PDT 
Committed r283062 (242120@main): <https://commits.webkit.org/242120@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439178 [details].
Comment 9 Radar WebKit Bug Importer 2021-09-24 15:14:19 PDT 
<rdar://problem/83513547>