| Summary: | WebGL first clear is lost when scissor is used for preserveDrawingBuffer:true in some conditions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=229989 https://bugs.webkit.org/show_bug.cgi?id=230613 |
||||||||||
| Attachments: |
|
||||||||||
Great find - let's try to write a conformance test for this once it's understood. Created attachment 439850 [details]
Patch
Created attachment 439852 [details]
Patch
Comment on attachment 439852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439852&action=review > LayoutTests/ChangeLog:9 > + done-scissor ? Created attachment 439969 [details]
Patch for landing
I defer to Dean's review, but have filed: Add test for scissor affecting compositing https://github.com/KhronosGroup/WebGL/issues/3337 to make sure this doesn't get lost, and is handled properly in other browsers. Committed r283979 (242825@main): <https://commits.webkit.org/242825@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439969 [details]. |
WebGL first clear is lost when scissor is used for preserveDrawingBuffer:true in some conditions Possibly c.enable(c.SCISSOR_TEST); c.clearColor(0., 1., 0., 0.5); c.scissor(0, 0, 300, 50); c.clear(c.COLOR_BUFFER_BIT); c.scissor(125, 50, 50, 50); c.clearColor(0., 1., 0., 1.); c.clear(c.COLOR_BUFFER_BIT); c.scissor(0, 0, 300, 50); c.clear(c.COLOR_BUFFER_BIT);