Bug 230592

Summary: Add FontCreationContext
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, macpherson, menard, ryuan.choi, sergio, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230446, 230449    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
zalan: review+, ews-feeder: commit-queue-
Patch for committing none

Myles C. Maxfield
Reported 2021-09-21 19:00:57 PDT
Add FontCreationContext
Attachments
Patch (56.77 KB, patch)
2021-09-21 19:05 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (59.46 KB, patch)
2021-09-21 19:18 PDT, Myles C. Maxfield 		zalan: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for committing (65.76 KB, patch)
2021-09-21 20:31 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-21 19:05:41 PDT
Created attachment 438903 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-09-21 19:06:20 PDT
<rdar://problem/83379889>
Myles C. Maxfield
Comment 3 2021-09-21 19:18:34 PDT
Created attachment 438906 [details] Patch
zalan
Comment 4 2021-09-21 20:05:34 PDT
Comment on attachment 438906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438906&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:579 > - auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 2, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); > + auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); TIL Pass 0 to specify that the maximum capacity is not limited.
Myles C. Maxfield
Comment 5 2021-09-21 20:31:39 PDT
Created attachment 438910 [details] Patch for committing
Myles C. Maxfield
Comment 6 2021-09-21 20:33:20 PDT
Comment on attachment 438906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438906&action=review >> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:579 >> + auto attributes = adoptCF(CFDictionaryCreateMutable(kCFAllocatorDefault, 0, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks)); > > TIL Pass 0 to specify that the maximum capacity is not limited. ❤️
Myles C. Maxfield
Comment 7 2021-09-21 21:06:24 PDT
Committed r282863 (241994@main): <https://commits.webkit.org/241994@main>
Note You need to log in before you can comment on or make changes to this bug.