Bug 230587

Summary: Remove ENABLE(SMOOTH_SCROLLING)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2021-09-21 17:14:24 PDT
Remove ENABLE(SMOOTH_SCROLLING)
Attachments
Patch (7.99 KB, patch)
2021-09-21 17:15 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (9.68 KB, patch)
2021-09-21 21:02 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-09-21 17:15:59 PDT
Created attachment 438892 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-09-21 21:02:44 PDT
Created attachment 438914 [details] Patch
Tim Horton
Comment 3 2021-09-21 21:14:58 PDT
Comment on attachment 438914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438914&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.h:29 > -#if ENABLE(SMOOTH_SCROLLING) > +#if PLATFORM(MAC) Kinda feel like semantic flags are better than PLATFORM() ones (but also that ENABLE(SMOOTH_SCROLLING) is meaningless so maybe this one is not a good example :D)
EWS
Comment 4 2021-09-22 08:03:11 PDT
Committed r282876 (242005@main): <https://commits.webkit.org/242005@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438914 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-22 08:04:25 PDT
<rdar://problem/83400738>
Note You need to log in before you can comment on or make changes to this bug.