Summary: | Remove ENABLE(SMOOTH_SCROLLING) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Scrolling | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, thorton, tonikitoo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2021-09-21 17:14:24 PDT
Created attachment 438892 [details]
Patch
Created attachment 438914 [details]
Patch
Comment on attachment 438914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438914&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.h:29 > -#if ENABLE(SMOOTH_SCROLLING) > +#if PLATFORM(MAC) Kinda feel like semantic flags are better than PLATFORM() ones (but also that ENABLE(SMOOTH_SCROLLING) is meaningless so maybe this one is not a good example :D) Committed r282876 (242005@main): <https://commits.webkit.org/242005@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438914 [details]. |