Bug 230587 - Remove ENABLE(SMOOTH_SCROLLING)
Summary: Remove ENABLE(SMOOTH_SCROLLING)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-21 17:14 PDT by Simon Fraser (smfr)
Modified: 2021-09-22 08:04 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.99 KB, patch)
2021-09-21 17:15 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (9.68 KB, patch)
2021-09-21 21:02 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-21 17:14:24 PDT 
Remove ENABLE(SMOOTH_SCROLLING)
Comment 1 Simon Fraser (smfr) 2021-09-21 17:15:59 PDT 
Created attachment 438892 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-09-21 21:02:44 PDT 
Created attachment 438914 [details]
Patch
Comment 3 Tim Horton 2021-09-21 21:14:58 PDT 
Comment on attachment 438914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438914&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:29
> -#if ENABLE(SMOOTH_SCROLLING)
> +#if PLATFORM(MAC)

Kinda feel like semantic flags are better than PLATFORM() ones (but also that ENABLE(SMOOTH_SCROLLING) is meaningless so maybe this one is not a good example :D)
Comment 4 EWS 2021-09-22 08:03:11 PDT 
Committed r282876 (242005@main): <https://commits.webkit.org/242005@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438914 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-22 08:04:25 PDT 
<rdar://problem/83400738>