Bug 230582

Summary:

[JSC] CompareStrictEq is omitting String check incorrectly

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, msalgado-cedillo618, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mark.lam: review+

Yusuke Suzuki

Reported 2021-09-21 16:11:01 PDT

[JSC] CompareStrictEq is omitting String check incorrectly

Attachments
Patch (12.83 KB, patch) 2021-09-21 16:14 PDT, Yusuke Suzuki	mark.lam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2021-09-21 16:14:04 PDT

Yusuke Suzuki

Comment 2 2021-09-21 16:14:07 PDT

Mark Lam

Comment 3 2021-09-21 17:25:11 PDT

Comment on attachment 438879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383 > JITCompiler::JumpList trueCase; Not due to your patch, but the comment above is incorrect: `if (left == true) {` ==> `if (left == right) {`

Yusuke Suzuki

Comment 4 2021-09-21 18:13:03 PDT

Comment on attachment 438879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383 >> JITCompiler::JumpList trueCase; > > Not due to your patch, but the comment above is incorrect: `if (left == true) {` ==> `if (left == right) {` Thanks, fixed.

Yusuke Suzuki

Comment 5 2021-09-21 18:14:14 PDT

Note You need to log in before you can comment on or make changes to this bug.