Bug 230582

Summary:

[JSC] CompareStrictEq is omitting String check incorrectly

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, msalgado-cedillo618, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mark.lam: review+

Description Yusuke Suzuki 2021-09-21 16:11:01 PDT

[JSC] CompareStrictEq is omitting String check incorrectly

Comment 1 Yusuke Suzuki 2021-09-21 16:14:04 PDT

Created attachment 438879 [details]
Patch

Comment 2 Yusuke Suzuki 2021-09-21 16:14:07 PDT

<rdar://problem/83237121>

Comment 3 Mark Lam 2021-09-21 17:25:11 PDT

Comment on attachment 438879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383
>      JITCompiler::JumpList trueCase;

Not due to your patch, but the comment above is incorrect: `if (left == true) {` ==> `if (left == right) {`

Comment 4 Yusuke Suzuki 2021-09-21 18:13:03 PDT

Comment on attachment 438879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383
>>      JITCompiler::JumpList trueCase;
> 
> Not due to your patch, but the comment above is incorrect: `if (left == true) {` ==> `if (left == right) {`

Thanks, fixed.

Comment 5 Yusuke Suzuki 2021-09-21 18:14:14 PDT

Committed r282857 (241988@main): <https://commits.webkit.org/241988@main>