Bug 230506

Summary: Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when used for scroll snap
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch wenson_hsieh: review+, ews-feeder: commit-queue-

Description Simon Fraser (smfr) 2021-09-20 13:41:55 PDT 
Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when used for scroll snap
Comment 1 Simon Fraser (smfr) 2021-09-20 13:45:38 PDT 
Created attachment 438723 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-09-20 14:08:43 PDT 
Created attachment 438727 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-09-20 16:36:44 PDT 
Created attachment 438752 [details]
Patch
Comment 4 Wenson Hsieh 2021-09-20 17:28:15 PDT 
Comment on attachment 438752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438752&action=review

> Source/WebCore/platform/ScrollAnimationMomentum.cpp:104
> +    auto predictedScrollOffset = m_momentumCalculator->predictedDestinationOffset();

Is `m_momentumCalculator` guaranteed to be non-null here because this should only be called for active animations?
Comment 5 Radar WebKit Bug Importer 2021-09-27 13:42:15 PDT 
<rdar://problem/83589190>
Comment 6 EWS 2021-09-29 07:40:54 PDT 
Tools/Scripts/svn-apply failed to apply attachment 438752 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 Simon Fraser (smfr) 2021-10-04 17:08:23 PDT 
http://trac.webkit.org/changeset/282798/webkit