Bug 230506 - Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when used for scroll snap
Summary: Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when used for s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-20 13:41 PDT by Simon Fraser (smfr)
Modified: 2021-10-04 17:08 PDT (History)
8 users (show)

See Also:


Attachments
Patch (23.64 KB, patch)
2021-09-20 13:45 PDT, Simon Fraser (smfr)
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (26.60 KB, patch)
2021-09-20 14:08 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (27.71 KB, patch)
2021-09-20 16:36 PDT, Simon Fraser (smfr)
wenson_hsieh: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-20 13:41:55 PDT
Wrap ScrollingMomentumCalculator in a ScrollAnimationMomentum when used for scroll snap
Comment 1 Simon Fraser (smfr) 2021-09-20 13:45:38 PDT
Created attachment 438723 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-09-20 14:08:43 PDT
Created attachment 438727 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-09-20 16:36:44 PDT
Created attachment 438752 [details]
Patch
Comment 4 Wenson Hsieh 2021-09-20 17:28:15 PDT
Comment on attachment 438752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438752&action=review

> Source/WebCore/platform/ScrollAnimationMomentum.cpp:104
> +    auto predictedScrollOffset = m_momentumCalculator->predictedDestinationOffset();

Is `m_momentumCalculator` guaranteed to be non-null here because this should only be called for active animations?
Comment 5 Radar WebKit Bug Importer 2021-09-27 13:42:15 PDT
<rdar://problem/83589190>
Comment 6 EWS 2021-09-29 07:40:54 PDT
Tools/Scripts/svn-apply failed to apply attachment 438752 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 Simon Fraser (smfr) 2021-10-04 17:08:23 PDT
http://trac.webkit.org/changeset/282798/webkit