Bug 230486

Summary: Use typed identifier for WebSocketChannel identifiers
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, hi, japhet, joepeck, pangle, toyoshim, webkit-bug-importer, youennf, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2021-09-20 10:32:19 PDT
Use typed identifier for WebSocketChannel identifiers
Attachments
Patch (33.35 KB, patch)
2021-09-20 10:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-09-20 10:33:15 PDT
Created attachment 438692 [details] Patch
youenn fablet
Comment 2 2021-09-21 00:10:03 PDT
Comment on attachment 438692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438692&action=review > Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.h:87 > + virtual WebSocketChannelIdentifier progressIdentifier() const = 0; Can we rename progressIdentifier as well to just identifier? > Source/WebCore/Modules/websockets/WebSocketChannelInspector.cpp:37 > + : m_progressIdentifier(WebSocketChannelIdentifier::generateThreadSafe()) { } I would have thought only WebSocketChannel would generate WebSocketChannelIdentifier, it is a bit odd but is a preexisting issue.
Alex Christensen
Comment 3 2021-09-21 08:06:33 PDT
It can also never be zero now, so I'll remove the if (m_progressIdentifier) checks.
Alex Christensen
Comment 4 2021-09-21 08:15:53 PDT
ThreadableWebSocketChannel already has identifier() which returns a WebSocketIdentifier
EWS
Comment 5 2021-09-21 08:24:25 PDT
Committed r282818 (241949@main): <https://commits.webkit.org/241949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438692 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-21 08:25:20 PDT
<rdar://problem/83352793>
Note You need to log in before you can comment on or make changes to this bug.