Bug 230482

Summary: Refactor some code that controls Live Text selection behavior
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch none

Wenson Hsieh
Reported 2021-09-20 07:54:34 PDT
rdar://83173597
Attachments
WIP (6.82 KB, patch)
2021-09-20 08:39 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (7.56 KB, patch)
2021-09-20 09:37 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-09-20 08:39:52 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-09-20 09:37:38 PDT
Created attachment 438687 [details] Patch
Megan Gardner
Comment 3 2021-09-20 10:09:56 PDT
Comment on attachment 438687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438687&action=review > Source/WebCore/page/EventHandler.cpp:2529 > + if (!candidateElement) Why did you expand this?
Wenson Hsieh
Comment 4 2021-09-20 11:08:57 PDT
Comment on attachment 438687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438687&action=review Thanks for the review! >> Source/WebCore/page/EventHandler.cpp:2529 >> + if (!candidateElement) > > Why did you expand this? Ah, good question. So I had actually inadvertently shrank this in https://trac.webkit.org/r282740, due to a mistake when breaking out my changes into these smaller patches :P (It was originally intended to be just one larger refactoring, but I split it into smaller pieces to make it easier to review).
EWS
Comment 5 2021-09-20 12:32:41 PDT
Committed r282769 (241904@main): <https://commits.webkit.org/241904@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438687 [details].
Note You need to log in before you can comment on or make changes to this bug.