Bug 230459

Summary: [lFC][Integration] Enable some text painting features
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237898
Attachments:
Description Flags
Patch none

Description Antti Koivisto 2021-09-19 06:59:03 PDT
some more coverage
Comment 1 Antti Koivisto 2021-09-19 07:35:14 PDT
Created attachment 438594 [details]
Patch
Comment 2 Sam Weinig 2021-09-19 09:44:33 PDT
Comment on attachment 438594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438594&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:63
> +    // Unused                                    = 1LLU  << 23,

Are you doing this so you don't have to change all the numbers after this one? Or do these need to stay consistent across builds for serialization reasons? (either is ok, just curious)
Comment 3 zalan 2021-09-19 09:46:35 PDT
(In reply to Sam Weinig from comment #2)
> Comment on attachment 438594 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438594&action=review
> 
> > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:63
> > +    // Unused                                    = 1LLU  << 23,
> 
> Are you doing this so you don't have to change all the numbers after this
> one? Or do these need to stay consistent across builds for serialization
> reasons? (either is ok, just curious)
The former. I tend to collapse it from time to time though.
Comment 4 EWS 2021-09-19 10:04:44 PDT
Committed r282737 (241874@main): <https://commits.webkit.org/241874@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438594 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-19 10:05:17 PDT
<rdar://problem/83285459>
Comment 6 Antti Koivisto 2021-09-19 10:33:27 PDT
Also makes patches collide less.