Bug 230448

Summary: Handle CSSOM style mutation of font-palette-values
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, mmaxfield, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 230446    
Attachments:
Description Flags
Patch
none
WIP
none
Patch ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2021-09-18 14:14:07 PDT
... as well as handling entire rules being deleted/added.
Attachments
Patch (10.29 KB, patch)
2021-09-23 01:01 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (15.93 KB, patch)
2021-09-23 20:06 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (17.64 KB, patch)
2021-09-23 20:51 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-20 23:18:28 PDT
https://github.com/w3c/csswg-drafts/issues/6645
Radar WebKit Bug Importer
Comment 2 2021-09-21 01:09:10 PDT
<rdar://problem/83343481>
Myles C. Maxfield
Comment 3 2021-09-23 00:14:39 PDT
CSSSegmentedFontFace::fontRanges()'s cache doesn't handle the palettes
Myles C. Maxfield
Comment 4 2021-09-23 00:20:03 PDT
For some reason a stale value is being used in CSSFontAccessor.
Myles C. Maxfield
Comment 5 2021-09-23 00:23:35 PDT
Whoops, scratch that last comment.
Myles C. Maxfield
Comment 7 2021-09-23 01:01:59 PDT
Created attachment 439018 [details] Patch Working on tests at https://github.com/litherum/wpt/commit/c9abc7278d6acdfbc3f5655653508cffd3f60b19
EWS Watchlist
Comment 8 2021-09-23 01:03:08 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Myles C. Maxfield
Comment 9 2021-09-23 20:06:57 PDT
Created attachment 439119 [details] WIP
Myles C. Maxfield
Comment 10 2021-09-23 20:18:37 PDT
WPT PR for tests at https://github.com/web-platform-tests/wpt/pull/30939
Myles C. Maxfield
Comment 11 2021-09-23 20:51:51 PDT
Created attachment 439120 [details] Patch
Myles C. Maxfield
Comment 12 2021-09-24 01:39:21 PDT
https://drafts.csswg.org/css-fonts-4/#font-face-src-parsing <font-technology> = [features(<font-feature-technology>) | variations | color(<color-font-technology>) | palettes | incremental ]
Myles C. Maxfield
Comment 13 2021-09-24 01:40:14 PDT
Whoops, disregard that last comment, it's meant for a different bug.
EWS
Comment 14 2021-09-24 01:48:55 PDT
Committed r283031 (242091@main): <https://commits.webkit.org/242091@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439120 [details].
Note You need to log in before you can comment on or make changes to this bug.