Summary: | [ macOS Release ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ayumi_kojima | ||||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, cdumez, ggaren, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Mac (Intel) | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
ayumi_kojima
2021-09-17 14:31:19 PDT
It looks like the test has been flaky since it was added at https://trac.webkit.org/changeset/282483/webkit I was not able to reproduce the timeout using run-api-tests TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50 Created attachment 438535 [details]
Patch
(In reply to ayumi_kojima from comment #4) > I was not able to reproduce the timeout using run-api-tests > TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50 Me neither so my fix is speculative. Comment on attachment 438535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228 > + TestWebKitAPI::Util::run(&finishedRunningScript); TestWKWebView has objectByEvaluatingJavaScript which does this. > Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241 > + } while (!canSecondWebViewSeeNewCookie); It should only take one try. Comment on attachment 438535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228 >> + TestWebKitAPI::Util::run(&finishedRunningScript); > > TestWKWebView has objectByEvaluatingJavaScript which does this. Oh, I'll look into it, thanks. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241 >> + } while (!canSecondWebViewSeeNewCookie); > > It should only take one try. That's definitely not true in practice. I don't know what would guarantee that. Created attachment 438536 [details]
Patch
Committed r282719 (241856@main): <https://commits.webkit.org/241856@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438536 [details]. |