Bug 230430

Summary:

[ macOS Release ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out

Product:

WebKit

Reporter:

ayumi_kojima

Component:

New Bugs

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, ggaren, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac (Intel)

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

ayumi_kojima

Reported 2021-09-17 14:31:19 PDT

TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery Is flaky timing out on macOS. History: [ macOS ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out Build page: https://build.webkit.org/#/builders/70/builds/5212

Attachments
Patch (4.81 KB, patch) 2021-09-17 16:54 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (4.43 KB, patch) 2021-09-17 17:31 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

ayumi_kojima

Comment 1 2021-09-17 14:39:36 PDT

It looks like the test has been flaky since it was added at https://trac.webkit.org/changeset/282483/webkit

Radar WebKit Bug Importer

Comment 2 2021-09-17 14:40:06 PDT

<rdar://problem/83256307>

ayumi_kojima

Comment 3 2021-09-17 14:42:07 PDT

History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery

ayumi_kojima

Comment 4 2021-09-17 15:15:41 PDT

I was not able to reproduce the timeout using run-api-tests TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50

Chris Dumez

Comment 5 2021-09-17 16:54:03 PDT

Created attachment 438535 [details] Patch

Chris Dumez

Comment 6 2021-09-17 16:59:57 PDT

(In reply to ayumi_kojima from comment #4) > I was not able to reproduce the timeout using run-api-tests > TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50 Me neither so my fix is speculative.

Alex Christensen

Comment 7 2021-09-17 17:02:11 PDT

Comment on attachment 438535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228 > + TestWebKitAPI::Util::run(&finishedRunningScript); TestWKWebView has objectByEvaluatingJavaScript which does this. > Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241 > + } while (!canSecondWebViewSeeNewCookie); It should only take one try.

Chris Dumez

Comment 8 2021-09-17 17:27:20 PDT

Comment on attachment 438535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228 >> + TestWebKitAPI::Util::run(&finishedRunningScript); > > TestWKWebView has objectByEvaluatingJavaScript which does this. Oh, I'll look into it, thanks. >> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241 >> + } while (!canSecondWebViewSeeNewCookie); > > It should only take one try. That's definitely not true in practice. I don't know what would guarantee that.

Chris Dumez

Comment 9 2021-09-17 17:31:48 PDT

Created attachment 438536 [details] Patch

EWS

Comment 10 2021-09-17 20:27:59 PDT

Committed r282719 (241856@main): <https://commits.webkit.org/241856@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438536 [details].

Note You need to log in before you can comment on or make changes to this bug.