Bug 230430

Summary: [ macOS Release ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out
Product: WebKit Reporter: ayumi_kojima
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, ggaren, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac (Intel)   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description ayumi_kojima 2021-09-17 14:31:19 PDT 
TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery

Is flaky timing out on macOS.

History: [ macOS ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out 

Build page: https://build.webkit.org/#/builders/70/builds/5212
Comment 1 ayumi_kojima 2021-09-17 14:39:36 PDT 
It looks like the test has been flaky since it was added at https://trac.webkit.org/changeset/282483/webkit
Comment 2 Radar WebKit Bug Importer 2021-09-17 14:40:06 PDT 
<rdar://problem/83256307>
Comment 4 ayumi_kojima 2021-09-17 15:15:41 PDT 
I was not able to reproduce the timeout using run-api-tests TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50
Comment 5 Chris Dumez 2021-09-17 16:54:03 PDT 
Created attachment 438535 [details]
Patch
Comment 6 Chris Dumez 2021-09-17 16:59:57 PDT 
(In reply to ayumi_kojima from comment #4)
> I was not able to reproduce the timeout using run-api-tests
> TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50

Me neither so my fix is speculative.
Comment 7 Alex Christensen 2021-09-17 17:02:11 PDT 
Comment on attachment 438535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228
> +    TestWebKitAPI::Util::run(&finishedRunningScript);

TestWKWebView has objectByEvaluatingJavaScript which does this.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241
> +    } while (!canSecondWebViewSeeNewCookie);

It should only take one try.
Comment 8 Chris Dumez 2021-09-17 17:27:20 PDT 
Comment on attachment 438535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228
>> +    TestWebKitAPI::Util::run(&finishedRunningScript);
> 
> TestWKWebView has objectByEvaluatingJavaScript which does this.

Oh, I'll look into it, thanks.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241
>> +    } while (!canSecondWebViewSeeNewCookie);
> 
> It should only take one try.

That's definitely not true in practice. I don't know what would guarantee that.
Comment 9 Chris Dumez 2021-09-17 17:31:48 PDT 
Created attachment 438536 [details]
Patch
Comment 10 EWS 2021-09-17 20:27:59 PDT 
Committed r282719 (241856@main): <https://commits.webkit.org/241856@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438536 [details].