Bug 230424

Summary: [Cocoa] Make AVSampleBufferVideoOutput support an Experimental Feature
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2021-09-17 13:15:36 PDT
[Cocoa] Make AVSampleBufferVideoOutput support an Experimental Feature
Attachments
Patch (8.83 KB, patch)
2021-09-17 13:19 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.40 KB, patch)
2021-09-17 14:02 PDT, Jer Noble 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.25 KB, patch)
2021-09-17 14:30 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (10.18 KB, patch)
2021-09-19 14:48 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (10.18 KB, patch)
2021-09-20 08:54 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2021-09-17 13:19:29 PDT
Created attachment 438507 [details] Patch
Jer Noble
Comment 2 2021-09-17 14:02:12 PDT
Created attachment 438514 [details] Patch
Jer Noble
Comment 3 2021-09-17 14:30:30 PDT
Created attachment 438516 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-09-17 15:36:29 PDT
<rdar://problem/83258211>
Jer Noble
Comment 5 2021-09-19 14:48:44 PDT
Created attachment 438624 [details] Patch
Eric Carlson
Comment 6 2021-09-20 08:51:32 PDT
Comment on attachment 438624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438624&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:920 > + return MediaSessionManagerCocoa::mediaSourceInlinePaintingEnabled() && PAL::getAVSampleBufferVideoOutputClass; Shouldn't this be `PAL::getAVSampleBufferVideoOutputClass()`?
Jer Noble
Comment 7 2021-09-20 08:52:22 PDT
(In reply to Eric Carlson from comment #6) > Comment on attachment 438624 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438624&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:920 > > + return MediaSessionManagerCocoa::mediaSourceInlinePaintingEnabled() && PAL::getAVSampleBufferVideoOutputClass; > > Shouldn't this be `PAL::getAVSampleBufferVideoOutputClass()`? Oof. Yes it should be.
Jer Noble
Comment 8 2021-09-20 08:54:13 PDT
Created attachment 438684 [details] Patch for landing
EWS
Comment 9 2021-09-20 09:52:50 PDT
Committed r282752 (241889@main): <https://commits.webkit.org/241889@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438684 [details].
Note You need to log in before you can comment on or make changes to this bug.