Bug 230423 – [ Catalina+ Win WK1 ] http/tests/misc/iframe-reparenting-id-collision.html is a flaky text failure

• Component: Page Loading
• Status: RESOLVED FIXED

[Robert Jenner]

http/tests/misc/iframe-reparenting-id-collision.html


is a flaky text failure when running on WK1 for Windows and Catalina+


HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fmisc%2Fiframe-reparenting-id-collision.html

TEXT DIFF:
--- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/tests/misc/iframe-reparenting-id-collision-expected.txt
+++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/tests/misc/iframe-reparenting-id-collision-actual.txt
@@ -5,4 +5,6 @@
 Beginning adoption sequence.
 PASS: adopted node without id collision
 PASS: adopted back to original page without id collision
+Started loading iframe XHR request.
+Beginning adoption sequence.

[Radar WebKit Bug Importer]

<rdar://problem/83252545>

[Robert Jenner]

I was able to easily reproduce this at Production ToT using the following test:


run-webkit-tests http/tests/misc/iframe-reparenting-id-collision.html --iterations 10 -1

[Robert Jenner]

I was able to reproduce the failure back to r282609. I then checked out my local repository to r282607, and ran the test again on the same revision, and it was not reproducible at that point.  


I even took --iterations up to 1000, and was not able to reproduce the failure with my local checkout at r282607, while running tests on r282609. 


So it appears that r282609 introduced the flaky failure.

[Chris Dumez]

Created attachment 438524 [details]
Patch

[Geoffrey Garen]

Comment on attachment 438524 [details]
Patch

r=me

[EWS]

Committed r282716 (241853@main): <https://commits.webkit.org/241853@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438524 [details].