Bug 230422

Summary: Add CustomToJSObject wrapper for CSSStyleValueCustom
Product: WebKit Reporter: Qiaosong Zhou <johnson.zhou.sh>
Component: New BugsAssignee: Qiaosong Zhou <johnson.zhou.sh>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175733    
Attachments:
Description Flags
Patch
none
Patch none

Qiaosong Zhou
Reported 2021-09-17 12:51:24 PDT
Add CustomToJSObject wrapper for CSSStyleValueCustom
Attachments
Patch (3.41 KB, patch)
2021-09-17 12:52 PDT, Qiaosong Zhou 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2021-09-17 13:46 PDT, Qiaosong Zhou 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Qiaosong Zhou
Comment 1 2021-09-17 12:52:09 PDT
Created attachment 438505 [details] Patch
Alex Christensen
Comment 2 2021-09-17 12:59:13 PDT
Comment on attachment 438505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438505&action=review > Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp:50 > + if (is<CSSUnparsedValue>(value)) Can this use a switch statement instead? switch(value->getType()) That way if someone adds more it'll be a compiler error instead of searching for the places they forgot to add code.
Qiaosong Zhou
Comment 3 2021-09-17 13:46:16 PDT
Created attachment 438511 [details] Patch
EWS
Comment 4 2021-09-17 16:15:53 PDT
Committed r282706 (241843@main): <https://commits.webkit.org/241843@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438511 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-17 16:16:24 PDT
<rdar://problem/83259645>
Note You need to log in before you can comment on or make changes to this bug.