| Summary: | Add CustomToJSObject wrapper for CSSStyleValueCustom | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Qiaosong Zhou <johnson.zhou.sh> | ||||||
| Component: | New Bugs | Assignee: | Qiaosong Zhou <johnson.zhou.sh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 175733 | ||||||||
| Attachments: |
|
||||||||
|
Description
Qiaosong Zhou
2021-09-17 12:51:24 PDT
Created attachment 438505 [details]
Patch
Comment on attachment 438505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438505&action=review > Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp:50 > + if (is<CSSUnparsedValue>(value)) Can this use a switch statement instead? switch(value->getType()) That way if someone adds more it'll be a compiler error instead of searching for the places they forgot to add code. Created attachment 438511 [details]
Patch
Committed r282706 (241843@main): <https://commits.webkit.org/241843@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438511 [details]. |