| Summary: | [LFC][Integration] Add some useful functions to iterators | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Antti Koivisto <koivisto> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2021-09-17 05:01:28 PDT
Created attachment 438462 [details]
Patch
Comment on attachment 438462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438462&action=review > Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h:138 > + enum class HyphenMode { Include, Ignore }; > + TextRun createTextRun(HyphenMode hyphenMode = HyphenMode::Include) const How does the caller decide whether it needs hyphen or not (as this decision is mostly driven by line breaking and the run already includes it In ::renderedContent()) > How does the caller decide whether it needs hyphen or not (as this decision
> is mostly driven by line breaking and the run already includes it In
> ::renderedContent())
You are right, kept the argument version internal and only exposed a version without any.
Created attachment 438473 [details]
Patch
Committed r282661 (241802@main): <https://commits.webkit.org/241802@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438473 [details]. |