Bug 230398

Summary: [LFC][Integration] Add some useful functions to iterators
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Antti Koivisto
Reported 2021-09-17 05:01:28 PDT
For future use
Attachments
Patch (13.68 KB, patch)
2021-09-17 05:04 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (12.93 KB, patch)
2021-09-17 07:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-17 05:04:42 PDT
Created attachment 438462 [details] Patch
zalan
Comment 2 2021-09-17 06:23:07 PDT
Comment on attachment 438462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438462&action=review > Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h:138 > + enum class HyphenMode { Include, Ignore }; > + TextRun createTextRun(HyphenMode hyphenMode = HyphenMode::Include) const How does the caller decide whether it needs hyphen or not (as this decision is mostly driven by line breaking and the run already includes it In ::renderedContent())
Antti Koivisto
Comment 3 2021-09-17 07:12:24 PDT
> How does the caller decide whether it needs hyphen or not (as this decision > is mostly driven by line breaking and the run already includes it In > ::renderedContent()) You are right, kept the argument version internal and only exposed a version without any.
Antti Koivisto
Comment 4 2021-09-17 07:28:16 PDT
Created attachment 438473 [details] Patch
EWS
Comment 5 2021-09-17 08:01:07 PDT
Committed r282661 (241802@main): <https://commits.webkit.org/241802@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438473 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-17 08:02:21 PDT
<rdar://problem/83241151>
Note You need to log in before you can comment on or make changes to this bug.