Bug 230393

Summary: [JSC] Add fast property enumeration mode for JSON.stringify
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, keith_miller, mark.lam, msaboff, philipj, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2021-09-17 01:35:08 PDT
[JSC] Add fast property enumeration mode for JSON.stringify
Attachments
Patch (10.91 KB, patch)
2021-09-17 01:35 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.91 KB, patch)
2021-09-17 01:36 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (18.69 KB, patch)
2021-09-17 01:51 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (21.77 KB, patch)
2021-09-17 03:49 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (24.59 KB, patch)
2021-09-17 04:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (30.29 KB, patch)
2021-09-17 12:41 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (30.50 KB, patch)
2021-09-17 12:51 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-09-17 01:35:48 PDT
Created attachment 438450 [details] Patch
Yusuke Suzuki
Comment 2 2021-09-17 01:36:55 PDT
Created attachment 438451 [details] Patch
Yusuke Suzuki
Comment 3 2021-09-17 01:51:18 PDT
Created attachment 438452 [details] Patch
Yusuke Suzuki
Comment 4 2021-09-17 03:49:30 PDT
Created attachment 438459 [details] Patch
Yusuke Suzuki
Comment 5 2021-09-17 04:53:48 PDT
Created attachment 438461 [details] Patch
Yusuke Suzuki
Comment 6 2021-09-17 12:41:00 PDT
Created attachment 438503 [details] Patch
Yusuke Suzuki
Comment 7 2021-09-17 12:51:01 PDT
Created attachment 438504 [details] Patch
Mark Lam
Comment 8 2021-09-17 14:58:40 PDT
Comment on attachment 438504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + This patch adds fast object property enumeration. When we know that source object has some conditions, we can say that, I suggest "has some conditions" ==> "meets some conditions". > Source/JavaScriptCore/runtime/JSONObject.cpp:96 > + bool isFastObjectProperties() const { return m_isFastObjectProperties; } nit: let's rename these to `hasFastObjectProperties()` and `m_hasFastObjectProperties`.
Yusuke Suzuki
Comment 9 2021-09-17 16:12:59 PDT
Comment on attachment 438504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:10 >> + This patch adds fast object property enumeration. When we know that source object has some conditions, we can say that, > > I suggest "has some conditions" ==> "meets some conditions". Fixed. >> Source/JavaScriptCore/runtime/JSONObject.cpp:96 >> + bool isFastObjectProperties() const { return m_isFastObjectProperties; } > > nit: let's rename these to `hasFastObjectProperties()` and `m_hasFastObjectProperties`. Changed.
Yusuke Suzuki
Comment 10 2021-09-17 16:17:31 PDT
Committed r282707 (241844@main): <https://commits.webkit.org/241844@main>
Radar WebKit Bug Importer
Comment 11 2021-09-17 16:18:19 PDT
<rdar://problem/83259718>
Note You need to log in before you can comment on or make changes to this bug.