Bug 230393

Summary: [JSC] Add fast property enumeration mode for JSON.stringify
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, keith_miller, mark.lam, msaboff, philipj, sbarati, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch mark.lam: review+

Description Yusuke Suzuki 2021-09-17 01:35:08 PDT
[JSC] Add fast property enumeration mode for JSON.stringify
Comment 1 Yusuke Suzuki 2021-09-17 01:35:48 PDT
Created attachment 438450 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-17 01:36:55 PDT
Created attachment 438451 [details]
Patch
Comment 3 Yusuke Suzuki 2021-09-17 01:51:18 PDT
Created attachment 438452 [details]
Patch
Comment 4 Yusuke Suzuki 2021-09-17 03:49:30 PDT
Created attachment 438459 [details]
Patch
Comment 5 Yusuke Suzuki 2021-09-17 04:53:48 PDT
Created attachment 438461 [details]
Patch
Comment 6 Yusuke Suzuki 2021-09-17 12:41:00 PDT
Created attachment 438503 [details]
Patch
Comment 7 Yusuke Suzuki 2021-09-17 12:51:01 PDT
Created attachment 438504 [details]
Patch
Comment 8 Mark Lam 2021-09-17 14:58:40 PDT
Comment on attachment 438504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +        This patch adds fast object property enumeration. When we know that source object has some conditions, we can say that,

I suggest "has some conditions" ==> "meets some conditions".

> Source/JavaScriptCore/runtime/JSONObject.cpp:96
> +        bool isFastObjectProperties() const { return m_isFastObjectProperties; }

nit: let's rename these to `hasFastObjectProperties()` and `m_hasFastObjectProperties`.
Comment 9 Yusuke Suzuki 2021-09-17 16:12:59 PDT
Comment on attachment 438504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:10
>> +        This patch adds fast object property enumeration. When we know that source object has some conditions, we can say that,
> 
> I suggest "has some conditions" ==> "meets some conditions".

Fixed.

>> Source/JavaScriptCore/runtime/JSONObject.cpp:96
>> +        bool isFastObjectProperties() const { return m_isFastObjectProperties; }
> 
> nit: let's rename these to `hasFastObjectProperties()` and `m_hasFastObjectProperties`.

Changed.
Comment 10 Yusuke Suzuki 2021-09-17 16:17:31 PDT
Committed r282707 (241844@main): <https://commits.webkit.org/241844@main>
Comment 11 Radar WebKit Bug Importer 2021-09-17 16:18:19 PDT
<rdar://problem/83259718>