Bug 230356

Summary: DumpRenderTree should clear a WebHTMLView static variable between tests
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: NEW    
Severity: Normal CC: ap, jbedard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch simon.fraser: review?

Simon Fraser (smfr)
Reported 2021-09-16 09:55:34 PDT
DumpRenderTree should clear a WebHTMLView static variable between tests
Attachments
Patch (4.51 KB, patch)
2021-09-16 09:56 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.54 KB, patch)
2021-09-16 10:02 PDT, Simon Fraser (smfr) 		simon.fraser: review?
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-09-16 09:56:25 PDT
Created attachment 438358 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-09-16 09:57:28 PDT
I did see behavior differences when debugging the failures in 230295 related to this static, but I don't know if this fixes any WK1 flakiness.
Simon Fraser (smfr)
Comment 3 2021-09-16 10:02:45 PDT
Created attachment 438360 [details] Patch
Alexey Proskuryakov
Comment 4 2021-09-16 11:45:41 PDT
Comment on attachment 438360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438360&action=review > Source/WebKitLegacy/mac/ChangeLog:8 > + Add testing-only SPI to clear the 'lastHitView' static in WebHTMLView. We navigate to about:blank between tests; should this not clear lastHitView?
Simon Fraser (smfr)
Comment 5 2021-09-16 12:02:30 PDT
It does not.
Alexey Proskuryakov
Comment 6 2021-09-16 18:02:54 PDT
Should it though? That seems like it may be a better fix than a test-only SPI.
Simon Fraser (smfr)
Comment 7 2021-09-16 19:11:20 PDT
I don't want to change WebKitLegacy behavior; that's all risk and little reward.
Radar WebKit Bug Importer
Comment 8 2021-09-23 09:56:27 PDT
<rdar://problem/83452466>
Alexey Proskuryakov
Comment 9 2021-09-23 17:53:20 PDT
I do not object to landing this, but don't feel excited enough to r+ given that isn't known to improve anything, and fixes the issue in a "wrong" way.
Note You need to log in before you can comment on or make changes to this bug.