Summary: | Move selection gap adjustment code form LegacyRootInlineBox to RenderBlockFlow | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | Layout and Rendering | Assignee: | Antti Koivisto <koivisto> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, changseok, dpino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2021-09-16 08:50:22 PDT
Created attachment 438355 [details]
Patch
Created attachment 438372 [details]
Patch
Zalan Bujtas found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 438374 [details]
Patch
Committed r282597 (241758@main): <https://commits.webkit.org/241758@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438374 [details]. The patch broke compilation in Ubuntu LTS/Debian bots: https://build.webkit.org/#/builders/68/builds/6643/steps/8/logs/stdio ``` In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-7.cpp:4: ../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp: In member function ‘WebCore::RenderObject::HighlightState WebCore::LayoutIntegration::PathRun::selectionState() const’: ../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp:103:29: error: invalid use of incomplete type ‘class WebCore::RenderView’ 103 | return renderer.view().selection().highlightStateForTextBox(renderer, text.selectableRange()); | ~~~~~~~~~~~~~^~ ``` Fixed in https://trac.webkit.org/changeset/282633/webkit |