Bug 230352

Summary: Move selection gap adjustment code form LegacyRootInlineBox to RenderBlockFlow
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dpino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antti Koivisto
Reported 2021-09-16 08:50:22 PDT
Move code out of legacy.
Attachments
Patch (13.75 KB, patch)
2021-09-16 09:27 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (13.76 KB, patch)
2021-09-16 11:09 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (13.76 KB, patch)
2021-09-16 11:21 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-16 09:27:42 PDT
Created attachment 438355 [details] Patch
Antti Koivisto
Comment 2 2021-09-16 11:09:23 PDT
Created attachment 438372 [details] Patch
EWS
Comment 3 2021-09-16 11:15:19 PDT
Zalan Bujtas found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Antti Koivisto
Comment 4 2021-09-16 11:21:41 PDT
Created attachment 438374 [details] Patch
EWS
Comment 5 2021-09-16 12:19:46 PDT
Committed r282597 (241758@main): <https://commits.webkit.org/241758@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438374 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-16 12:20:18 PDT
<rdar://problem/83208277>
Diego Pino
Comment 7 2021-09-16 22:18:23 PDT
The patch broke compilation in Ubuntu LTS/Debian bots: https://build.webkit.org/#/builders/68/builds/6643/steps/8/logs/stdio ``` In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-7.cpp:4: ../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp: In member function ‘WebCore::RenderObject::HighlightState WebCore::LayoutIntegration::PathRun::selectionState() const’: ../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp:103:29: error: invalid use of incomplete type ‘class WebCore::RenderView’ 103 | return renderer.view().selection().highlightStateForTextBox(renderer, text.selectableRange()); | ~~~~~~~~~~~~~^~ ``` Fixed in https://trac.webkit.org/changeset/282633/webkit
Note You need to log in before you can comment on or make changes to this bug.