Bug 230328

Summary:

Allow use of --git-index and --git-commit at the same time when using with --only-files

Product:

WebKit

Reporter:

Hoa Dinh <dvh>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Hoa Dinh

Reported 2021-09-15 17:09:45 PDT

We should we be able to use --git-index and --git-commit to asks for the list of changes between the specific commit and HEAD plus the current git index. Since it's mainly useful in the case of --only-files, we'll allow it only for this case.

Attachments
Patch (1.80 KB, patch) 2021-09-15 17:33 PDT, Hoa Dinh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hoa Dinh

Comment 1 2021-09-15 17:33:01 PDT

Created attachment 438308 [details] Patch

EWS

Comment 2 2021-09-16 11:08:21 PDT

Committed r282562 (241750@main): <https://commits.webkit.org/241750@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438308 [details].

Radar WebKit Bug Importer

Comment 3 2021-09-16 11:09:15 PDT

<rdar://problem/83205119>

Note You need to log in before you can comment on or make changes to this bug.