Bug 230311

Summary: Use std::optional for truncation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mmaxfield, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Antti Koivisto
Reported 2021-09-15 11:03:24 PDT
Remove constants
Attachments
Patch (16.00 KB, patch)
2021-09-15 11:17 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (15.97 KB, patch)
2021-09-15 11:19 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (16.88 KB, patch)
2021-09-16 00:35 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-15 11:17:47 PDT
Created attachment 438262 [details] Patch
Antti Koivisto
Comment 2 2021-09-15 11:19:55 PDT
Created attachment 438263 [details] Patch
Myles C. Maxfield
Comment 3 2021-09-15 11:55:20 PDT
Comment on attachment 438263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438263&action=review > Source/WebCore/rendering/LegacyInlineTextBox.h:70 > + auto truncation() const { return m_truncation; } 🤯
Antti Koivisto
Comment 4 2021-09-16 00:35:17 PDT
Created attachment 438323 [details] Patch
EWS
Comment 5 2021-09-16 03:32:34 PDT
Committed r282530 (241741@main): <https://commits.webkit.org/241741@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438323 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-16 03:33:33 PDT
<rdar://problem/83190577>
Note You need to log in before you can comment on or make changes to this bug.