Bug 230311

Summary: Use std::optional for truncation
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mmaxfield, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2021-09-15 11:03:24 PDT 
Remove constants
Comment 1 Antti Koivisto 2021-09-15 11:17:47 PDT 
Created attachment 438262 [details]
Patch
Comment 2 Antti Koivisto 2021-09-15 11:19:55 PDT 
Created attachment 438263 [details]
Patch
Comment 3 Myles C. Maxfield 2021-09-15 11:55:20 PDT 
Comment on attachment 438263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438263&action=review

> Source/WebCore/rendering/LegacyInlineTextBox.h:70
> +    auto truncation() const { return m_truncation; }

🤯
Comment 4 Antti Koivisto 2021-09-16 00:35:17 PDT 
Created attachment 438323 [details]
Patch
Comment 5 EWS 2021-09-16 03:32:34 PDT 
Committed r282530 (241741@main): <https://commits.webkit.org/241741@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438323 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-16 03:33:33 PDT 
<rdar://problem/83190577>