Bug 23029
| Summary: | REGRESSION (r39337): jsfunfuzz generates identical test files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | zimmermann, zwarich |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Oliver Hunt
jsfunfuzz uses Math.random() to generate random test resutls. Prior to squirrelfish it generated different results for every test file. Now the files are all identical
12/29/08 5:59 PM Oliver Hunt:
The unification of the random number generation in r39337 made random number generation always start with the same seed in JSC. This is non-standard behaviour based on both our old behaviour and that of other browsers.
<rdar://problem/6469185>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Cameron Zwarich (cpst)
What's a good fix for this problem?
Oliver Hunt
Bad Niko, seeding random but then using rand()
Cameron Zwarich (cpst)
Fixed in r39507:
http://trac.webkit.org/changeset/39507
Nikolas Zimmermann
Ouch, thanks a lot for fixing Cameron :-)