| Summary: | [Win] JSRemoteInspector.h missing stdint include | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||
| Component: | New Bugs | Assignee: | Ross Kirsling <ross.kirsling> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | don.olmstead, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ross Kirsling
2021-09-14 13:46:31 PDT
Created attachment 438163 [details]
Patch
Comment on attachment 438163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438163&action=review r=me with nits. > Source/JavaScriptCore/ChangeLog:3 > + [WinCairo] Add missing include for testapi I would have this be [Win] JSRemoteInspector.h missing stdint include At one point we found it with testapi but the actual reason is were missing a definition for uint8_t when including JSRemoteInspector.h on its own. > Source/JavaScriptCore/ChangeLog:7 > + Reason is basically "Include stdint for uint8_t definition on Windows" Created attachment 438166 [details]
Patch
Committed r282413 (241672@main): <https://commits.webkit.org/241672@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438166 [details]. |