| Summary: | Cache resource paths in run-jsc-stress-tests for speedup | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geza Lore <glore> | ||||||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | aperez, mark.lam, ross.kirsling, webkit-bug-importer, ysuzuki, zdobersek | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Geza Lore
2021-09-14 06:50:05 PDT
Created attachment 438133 [details]
Patch
Created attachment 438136 [details]
Patch
Created attachment 438137 [details]
Patch
Created attachment 438138 [details]
Patch
Created attachment 438140 [details]
Patch
Created attachment 438170 [details]
Patch
Created attachment 438223 [details]
Patch
Comment on attachment 438223 [details]
Patch
Minor note: This is one of my first time contributions to the WebKit project, so please educate me on process if I got something wrong. The patch is hopefully uncontroversial.
(In reply to Geza Lore from comment #8) > Comment on attachment 438223 [details] > Patch > > Minor note: This is one of my first time contributions to the WebKit > project, so please educate me on process if I got something wrong. The patch > is hopefully uncontroversial. The patch was all good, thanks! The most typical first-time contribution issues are missing or badly formatted ChangeLog entries in the submitted patches. Running `check-webkit-style` locally or looking at the messages when the “style” EWS bubble is not green goes a long way to pave the way =) (In reply to Adrian Perez from comment #9) > (In reply to Geza Lore from comment #8) > > Comment on attachment 438223 [details] > > Patch > > > > Minor note: This is one of my first time contributions to the WebKit > > project, so please educate me on process if I got something wrong. The patch > > is hopefully uncontroversial. > > The patch was all good, thanks! The most typical first-time contribution > issues are missing or badly formatted ChangeLog entries in the submitted > patches. Running `check-webkit-style` locally or looking at the messages > when the “style” EWS bubble is not green goes a long way to pave the way > =) If something, you could have set the cq? flag to request that the patch gets approved for merging (“cq” stands for “commit queue“). I have set the flag to cq+ because I assumed that you want the patch to be merged right after getting the r+ with the approval. Committed r282465 (241713@main): <https://commits.webkit.org/241713@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438223 [details]. |