| Summary: | Fix multiple issues with appcache online whitelist handling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2008-12-29 03:41:35 PST
Created attachment 26288 [details]
proposed patch
Comment on attachment 26288 [details] proposed patch > + unsigned whitelistSize = m_onlineWhitelist.size(); > + for (unsigned i = 0; i < whitelistSize; ++i) { We normally use size_t to iterate vectors. > + unsigned whitelistSize = onlineWhitelist.size(); > + for (unsigned i = 0; i < whitelistSize; ++i) { Ditto. For scaling, with large whitelists, it seems we might want to come up with a hash function so we can use a hashed set rather than a vector. > +# This should work normally. > +counter.php?uncached > \ No newline at end of file Can we add a newline? r=me (In reply to comment #2) > For scaling, with large whitelists, it seems we might want to come up with a > hash function so we can use a hashed set rather than a vector. I'm not aware of any way to use a hash function for prefix matching. We could use a tree though. But I doubt that whitelists will be very large. > > +# This should work normally. > > +counter.php?uncached > > \ No newline at end of file > > Can we add a newline? I didn't add it intentionally - I wanted to have a test for parsing such a manifest. Committed revision 39548. |