Summary: | [webkitpy] AutoInstall broken on Linux | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | ews-watchlist, glenn, jbedard, mcatanzaro, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Philippe Normand
2021-09-13 02:21:55 PDT
I landed r282322 as an emergency fix for EWS/etc bots. I am not sure why this custom cacert is needed in the first place. Is it due to a Python limitation on Apple platforms? In linux we can usually assume the host has valid root certificates, otherwise, maybe we could bootstrap 'certifi' before installing setuptools? That would likely avoid the need for a custom cert in the first place. A large number of Apple's bots rely on a different pypi source for their packages, and we have a bit of a chicken-egg problem with getting that cacert. Basically, the cacert in webkitcorepy isn't just for pypi.org. Will get it updated, this is the cost of owning the cacert.... Might want to rename the file to avoid confusion with http://www.cacert.org/ ;) Created attachment 438742 [details]
Move Linux special case to webkitpy
Created attachment 438746 [details]
Add root CA
I think we'd prefer the second one, but if we aren't going to do that, we should do the first so that the Linux special case is in webkitpy and doesn't apply to other callers of webkitpy I'll try to test tomorrow. |