| Summary: | Add unit test that uses PCM daemon | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Alex Christensen
2021-09-11 10:53:39 PDT
Created attachment 437959 [details]
Patch
Created attachment 437962 [details]
Patch
Created attachment 437979 [details]
Patch
Created attachment 438057 [details]
Patch
Comment on attachment 438057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:45 > + Connection(CString&& machServiceName); explicit > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:53 > + const CString m_machServiceName; Would be nice to have a blank line to separate data members from member functions. > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:75 > + : m_connection(machServiceName.utf8()) { } Don't we usually put the { } on the next line? Comment on attachment 438057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review >> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:75 >> + : m_connection(machServiceName.utf8()) { } > > Don't we usually put the { } on the next line? This is more and more common in WebKit when constructors don't do anything except initialize member variables. Created attachment 438077 [details]
Patch
Created attachment 438078 [details]
Patch
|