Bug 230190

Summary: Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains property methods
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, katherine_cheney, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210620    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
ews-feeder: commit-queue-
Patch v2 none

Description David Kilzer (:ddkilzer) 2021-09-11 10:49:48 PDT 
Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains property methods when building for iOS:

ld: warning: method '-limitsNavigationsToAppBoundDomains' in category from WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o overrides method from class in WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o
ld: warning: method '-setLimitsNavigationsToAppBoundDomains:' in category from WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o overrides method from class in WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o

This happens because the methods are implemented in category WKWebViewConfiguration (WKPrivate), but should be moved to WKWebViewConfiguration since the property was added as API in r260228.
Comment 1 David Kilzer (:ddkilzer) 2021-09-11 10:52:53 PDT 
Created attachment 437958 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2021-09-11 11:07:30 PDT 
Comment on attachment 437958 [details]
Patch v1

This needs PLATFORM(IOS) guards.
Comment 3 David Kilzer (:ddkilzer) 2021-09-11 11:56:57 PDT 
Created attachment 437961 [details]
Patch v2
Comment 4 Kate Cheney 2021-09-12 19:39:23 PDT 
Comment on attachment 437961 [details]
Patch v2

r=me
Comment 5 EWS 2021-09-13 10:01:24 PDT 
Committed r282332 (241600@main): <https://commits.webkit.org/241600@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437961 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-13 10:02:22 PDT 
<rdar://problem/83060079>