Bug 230183

Summary: [PlayStation][MiniBrowser] Remove WebKit private header include
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: Tools / TestsAssignee: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Status: RESOLVED FIXED    
Severity: Normal CC: ross.kirsling, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230170
Attachments:
Description Flags
Patch
none
Patch none

Yoshiaki Jitsukawa
Reported 2021-09-10 17:08:04 PDT
PlayStation MiniBrowser is expected to be independent of WebKit private headers (i.e. it should depend only on WK API.) in order to ensure that we can make a WebBrowser without those headers.
Attachments
Patch (1.73 KB, patch)
2021-09-10 17:14 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2021-09-12 15:45 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2021-09-10 17:14:52 PDT
Created attachment 437929 [details] Patch
Yoshiaki Jitsukawa
Comment 2 2021-09-12 15:45:11 PDT
Created attachment 437997 [details] Patch
Stephan Szabo
Comment 3 2021-09-13 10:15:46 PDT
Seems good. For the future, should we also be trying to remove the dependency on cmakeconfig.h?
Radar WebKit Bug Importer
Comment 4 2021-09-17 17:09:20 PDT
<rdar://problem/83261199>
EWS
Comment 5 2021-09-21 14:09:20 PDT
Committed r282840 (241971@main): <https://commits.webkit.org/241971@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437997 [details].
Note You need to log in before you can comment on or make changes to this bug.