| Summary: | Fix the lldb WTF::HashTable summary provider | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | achristensen, dbates, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-09-09 19:08:37 PDT
Created attachment 437824 [details]
Patch
Comment on attachment 437824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437824&action=review Have you run the unit tests for this? EWS doesn't. > Tools/lldb/lldb_webkit.py:-1076 > - table_pointer = self.valobj.GetChildMemberWithName('m_tableForLLDB') Should we also remove m_tableForLLDB from source then? I think we could remove m_tableForLLDB, yeah. I did test it, and the lldb tests passed (but, oddly, they passed before this change, when the provider was certainly broken for me). |