| Summary: | Fix some lldb data provider issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dbates, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-09-09 16:46:24 PDT
Created attachment 437805 [details]
Patch
Comment on attachment 437805 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437805&action=review Patch looks good. > Tools/lldb/lldbWebKitTester/main.cpp:33 > +#include <wtf/URL.h> Ok as is. Thoughts on putting this in sorted order? > Tools/lldb/lldb_webkit.py:487 > + def _is_outOfLine(self, rgba_and_flags): Ok as is. How about using snake casing for consistency? > Tools/lldb/lldb_webkit.py:509 > + out_of_line_components = self.valobj.CreateValueFromAddress('out_of_line_components', rgba_and_flags & self.COLOR_VALUE_MASK, out_of_line_components_type) I didn't know there was such a convenience API for this. Nice. |