Bug 230075

Summary: generated MessageArgumentDescriptions.cpp can't compile for non-Cocoa ports due to missing headers
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebKit2Assignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, kkinnunen, rniwa, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217688
https://bugs.webkit.org/show_bug.cgi?id=230064
https://bugs.webkit.org/show_bug.cgi?id=241854
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2021-09-08 18:06:29 PDT
generated MessageArgumentDescriptions.cpp can't compile for non-Cocoa ports due to missing headers It includes platform specific headers unconditionally. > WebKit\DerivedSources\MessageArgumentDescriptions.cpp(366): fatal error C1083: Cannot open include file: 'WebCore/CAAudioStreamDescription.h': No such file or directory generate_message_argument_description_implementation generates the #includes, it should take receiver.condition into account.
Attachments
Patch (9.32 KB, patch)
2021-09-08 18:25 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-09-08 18:25:26 PDT
Created attachment 437693 [details] Patch
Fujii Hironori
Comment 2 2021-09-08 20:31:18 PDT
Comment on attachment 437693 [details] Patch Clearing flags on attachment: 437693 Committed r282190 (241477@main): <https://commits.webkit.org/241477@main>
Fujii Hironori
Comment 3 2021-09-08 20:31:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2021-09-08 20:32:18 PDT
<rdar://problem/82906144>
Note You need to log in before you can comment on or make changes to this bug.