Regression (r282130): [ macOS iOS wk2 ] imported/w3c/web-platform-tests/storage/persisted.https.any.html is failing

• Component: New Bugs
• Status: RESOLVED FIXED

imported/w3c/web-platform-tests/storage/persisted.https.any.html 

Is failing on macOS wk2 and iOS.

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fstorage%2Fpersisted.https.any.html

Diff:

--- /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/storage/persisted.https.any-expected.txt
+++ /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/storage/persisted.https.any-actual.txt
@@ -1,4 +1,4 @@
 
 PASS persisted() method exists and returns a Promise
-PASS persisted() returns a promise and resolves as boolean with false
+FAIL persisted() returns a promise and resolves as boolean with false assert_equals: expected false but got true
 
According to the history, it looks like the test started failing at https://trac.webkit.org/changeset/282130/webkit

[Radar WebKit Bug Importer]

<rdar://problem/82879548>

[Sihui Liu]

Created attachment 437653 [details]
Patch

[Chris Dumez]

Comment on attachment 437653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437653&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2424
> +    completionHandler();

This call the completion handler before the storage is actually cleared on the background thread.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2159
> +    auto callbackAggregator = CallbackAggregator::create(WTFMove(completionHandler));

Why are we using a callback aggregator for a single function call? Just pass the completion handler to clearStorage().

> Tools/ChangeLog:9
> +        Clear storage states between tests so test does not affect each other.

test does -> tests do

[Sihui Liu]

Created attachment 437654 [details]
Patch

[Sihui Liu]

Created attachment 437655 [details]
Patch

[Sihui Liu]

Comment on attachment 437655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437655&action=review

> Source/WebKit/ChangeLog:11
> +        Coverd by existing tests.

Typo: Covered

[Sihui Liu]

Created attachment 437661 [details]
Patch for landing

[EWS]

Committed r282170 (241462@main): <https://commits.webkit.org/241462@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437661 [details].

[Eric Hutchison]

*** Bug 230068 has been marked as a duplicate of this bug. ***