Bug 230050

Summary: [ MacOS wk1 ] plugins/get-url-that-the-resource-load-delegate-will-disallow.html is a flaky crash
Product: WebKit Reporter: ayumi_kojima
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229881
Attachments:
Description Flags
Crash log
none
Patch none

Description ayumi_kojima 2021-09-08 09:35:16 PDT
plugins/get-url-that-the-resource-load-delegate-will-disallow.html

Is a flaky crash on BigSur wk1 and Catalina wk 1.

History: https://results.webkit.org/?suite=layout-tests&test=plugins%2Fget-url-that-the-resource-load-delegate-will-disallow.html

Result page: https://build.webkit.org/results/Apple-BigSur-Debug-WK1-Tests/r282140%20(4040)/results.html

Crash log:

2021-09-08 07:56:06.488 DumpRenderTree[65016:105904376] nil host used in call to allowsSpecificHTTPSCertificateForHost
2021-09-08 07:56:06.488 DumpRenderTree[65016:105904376] nil host used in call to allowsAnyHTTPSCertificateForHost:
ASSERTION FAILED: gTestRunner->waitToDump()
/Volumes/Data/worker/bigsur-debug/build/Tools/DumpRenderTree/mac/UIDelegate.mm(179) : -[UIDelegate webView:createWebViewWithRequest:]
1   0x10688afd9 WTFCrash
2   0x10515d36b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x10525a3de -[UIDelegate webView:createWebViewWithRequest:]
4   0x146b8d4fe -[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]
5   0x7fff206dfdbc __invoking___
6   0x7fff206dfc5d -[NSInvocation invoke]
7   0x7fff2070f7b5 -[NSInvocation invokeWithTarget:]
8   0x146b25251 -[_WebSafeForwarder forwardInvocation:]
9   0x7fff206de696 ___forwarding___
10  0x7fff206de2d8 _CF_forwarding_prep_0
11  0x146959596 WebKit::NetscapePluginInstanceProxy::performRequest(WebKit::NetscapePluginInstanceProxy::PluginRequest*)
12  0x146954e38 WebKit::NetscapePluginInstanceProxy::requestTimerFired()
13  0x14697c8a7 decltype(*(std::__1::forward<WebKit::NetscapePluginInstanceProxy*&>(fp0)).*fp()) std::__1::__invoke<void (WebKit::NetscapePluginInstanceProxy::*&)(), WebKit::NetscapePluginInstanceProxy*&, void>(void (WebKit::NetscapePluginInstanceProxy::*&)(), WebKit::NetscapePluginInstanceProxy*&)
14  0x14697c820 std::__1::__bind_return<void (WebKit::NetscapePluginInstanceProxy::*)(), std::__1::tuple<WebKit::NetscapePluginInstanceProxy*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::NetscapePluginInstanceProxy::*)(), std::__1::tuple<WebKit::NetscapePluginInstanceProxy*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (WebKit::NetscapePluginInstanceProxy::*)(), std::__1::tuple<WebKit::NetscapePluginInstanceProxy*>, 0ul, std::__1::tuple<> >(void (WebKit::NetscapePluginInstanceProxy::*&)(), std::__1::tuple<WebKit::NetscapePluginInstanceProxy*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&)
15  0x14697c7d9 std::__1::__bind_return<void (WebKit::NetscapePluginInstanceProxy::*)(), std::__1::tuple<WebKit::NetscapePluginInstanceProxy*>, std::__1::tuple<>, __is_valid_bind_return<void (WebKit::NetscapePluginInstanceProxy::*)(), std::__1::tuple<WebKit::NetscapePluginInstanceProxy*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (WebKit::NetscapePluginInstanceProxy::*&)(), WebKit::NetscapePluginInstanceProxy*>::operator()<>()
16  0x14697c75e WTF::Detail::CallableWrapper<std::__1::__bind<void (WebKit::NetscapePluginInstanceProxy::*&)(), WebKit::NetscapePluginInstanceProxy*>, void>::call()
17  0x146965472 WTF::Function<void ()>::operator()() const
18  0x14696538e WebCore::Timer::fired()
19  0x12f7f4fb4 WebCore::ThreadTimers::sharedTimerFiredInternal()
20  0x12f7ffca1 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const
21  0x12f7ffc2e WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call()
22  0x12b46ca62 WTF::Function<void ()>::operator()() const
23  0x12f7a38ab WebCore::MainThreadSharedTimer::fired()
24  0x12f88bb06 WebCore::timerFired(__CFRunLoopTimer*, void*)
25  0x7fff207152b9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__
26  0x7fff20714dad __CFRunLoopDoTimer
27  0x7fff2071490a __CFRunLoopDoTimers
28  0x7fff206fb4d3 __CFRunLoopRun
29  0x7fff206fa64c CFRunLoopRunSpecific
30  0x1051807eb runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
31  0x10517fa4a runTestingServerLoop()
Comment 1 Radar WebKit Bug Importer 2021-09-08 09:37:29 PDT
<rdar://problem/82877497>
Comment 2 ayumi_kojima 2021-09-08 09:38:08 PDT
Created attachment 437639 [details]
Crash log
Comment 3 ayumi_kojima 2021-09-08 09:41:16 PDT
Looking at the history,  it appears that the flaky crash initially started at https://trac.webkit.org/changeset/282025/webkit and started again at https://trac.webkit.org/changeset/282103/webkit
Comment 4 ayumi_kojima 2021-09-08 09:42:15 PDT
Updating test expectations soon.
Comment 5 ayumi_kojima 2021-09-08 09:46:13 PDT
The test is showing up on EWS as a flaky test. Updated test expectations to speed up EWS. https://trac.webkit.org/changeset/282147/webkit
Comment 6 Chris Dumez 2021-09-08 09:52:54 PDT
Created attachment 437641 [details]
Patch
Comment 7 Chris Dumez 2021-09-08 10:24:26 PDT
Comment on attachment 437641 [details]
Patch

Clearing flags on attachment: 437641

Committed r282156 (241448@main): <https://commits.webkit.org/241448@main>
Comment 8 Chris Dumez 2021-09-08 10:24:29 PDT
All reviewed patches have been landed.  Closing bug.