Bug 229881 - Allow layout tests to open popups by default
Summary: Allow layout tests to open popups by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 229908 229970
Blocks:
  Show dependency tree / graph
 
Reported: 2021-09-03 10:43 PDT by Chris Dumez
Modified: 2021-09-08 09:36 PDT (History)
25 users (show)

See Also:

Attachments
WIP patch (207.90 KB, patch)
2021-09-03 10:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (256.50 KB, patch)
2021-09-03 12:09 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (256.60 KB, patch)
2021-09-07 08:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (256.54 KB, patch)
2021-09-07 10:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-09-03 10:43:20 PDT 
Allow layout tests to open popups by defaults.
Comment 1 Chris Dumez 2021-09-03 10:43:52 PDT 
Created attachment 437284 [details]
WIP patch
Comment 2 Chris Dumez 2021-09-03 12:09:24 PDT 
Created attachment 437292 [details]
Patch
Comment 3 EWS 2021-09-03 14:47:31 PDT 
Committed r282025 (241329@main): <https://commits.webkit.org/241329@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437292 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-03 14:48:17 PDT 
<rdar://problem/82740249>
Comment 5 Aakash Jain 2021-09-06 15:32:39 PDT 
(In reply to EWS from comment #3)
> Committed r282025 (241329@main): <https://commits.webkit.org/241329@main>
This seems to have broken editing/pasteboard/paste-contents-with-side-effects.html 

History: https://results.webkit.org/?suite=layout-tests&test=editing%2Fpasteboard%2Fpaste-contents-with-side-effects.html
Comment 7 WebKit Commit Bot 2021-09-06 15:35:08 PDT 
Re-opened since this is blocked by bug 229970
Comment 9 Chris Dumez 2021-09-07 08:08:43 PDT 
Created attachment 437504 [details]
Patch
Comment 10 EWS 2021-09-07 10:41:08 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 11 Chris Dumez 2021-09-07 10:45:34 PDT 
Created attachment 437530 [details]
Patch
Comment 12 EWS 2021-09-07 11:49:00 PDT 
Committed r282103 (241401@main): <https://commits.webkit.org/241401@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437530 [details].