WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229881
Allow layout tests to open popups by default
https://bugs.webkit.org/show_bug.cgi?id=229881
Summary
Allow layout tests to open popups by default
Chris Dumez
Reported
2021-09-03 10:43:20 PDT
Allow layout tests to open popups by defaults.
Attachments
WIP patch
(207.90 KB, patch)
2021-09-03 10:43 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(256.50 KB, patch)
2021-09-03 12:09 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(256.60 KB, patch)
2021-09-07 08:08 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(256.54 KB, patch)
2021-09-07 10:45 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2021-09-03 10:43:52 PDT
Created
attachment 437284
[details]
WIP patch
Chris Dumez
Comment 2
2021-09-03 12:09:24 PDT
Created
attachment 437292
[details]
Patch
EWS
Comment 3
2021-09-03 14:47:31 PDT
Committed
r282025
(
241329@main
): <
https://commits.webkit.org/241329@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 437292
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-09-03 14:48:17 PDT
<
rdar://problem/82740249
>
Aakash Jain
Comment 5
2021-09-06 15:32:39 PDT
(In reply to EWS from
comment #3
)
> Committed
r282025
(
241329@main
): <
https://commits.webkit.org/241329@main
>
This seems to have broken editing/pasteboard/paste-contents-with-side-effects.html History:
https://results.webkit.org/?suite=layout-tests&test=editing%2Fpasteboard%2Fpaste-contents-with-side-effects.html
Aakash Jain
Comment 6
2021-09-06 15:34:18 PDT
on mac-debug-wk1 e.g.:
https://build.webkit.org/results/Apple-BigSur-Debug-WK1-Tests/r282026%20(3974)/results.html
WebKit Commit Bot
Comment 7
2021-09-06 15:35:08 PDT
Re-opened since this is blocked by
bug 229970
Aakash Jain
Comment 8
2021-09-06 15:42:18 PDT
Also broke: - plugins/get-url-with-blank-target.html - fast/html/marquee-reparent-check.html History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=editing%2Fpasteboard%2Fpaste-contents-with-side-effects.html&test=plugins%2Fget-url-with-blank-target.html&test=fast%2Fhtml%2Fmarquee-reparent-check.html
Chris Dumez
Comment 9
2021-09-07 08:08:43 PDT
Created
attachment 437504
[details]
Patch
EWS
Comment 10
2021-09-07 10:41:08 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Chris Dumez
Comment 11
2021-09-07 10:45:34 PDT
Created
attachment 437530
[details]
Patch
EWS
Comment 12
2021-09-07 11:49:00 PDT
Committed
r282103
(
241401@main
): <
https://commits.webkit.org/241401@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 437530
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug