Bug 230048

Summary: Floated <br> should not trigger a line break
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: NEW ---    
Severity: Normal CC: ahmad.saleem792, bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
URL: https://jsfiddle.net/Lf79njp5/show
See Also: https://bugs.webkit.org/show_bug.cgi?id=259631

Description Simon Fraser (smfr) 2021-09-08 09:25:56 PDT
https://github.com/w3c/csswg-drafts/issues/5749
Comment 1 Radar WebKit Bug Importer 2021-09-15 09:26:21 PDT
<rdar://problem/83154050>
Comment 2 Ahmad Saleem 2023-07-04 04:21:05 PDT
Safari / WebKit ToT matches Chrome Canary 118 while Firefox Nightly 116 differs from both.

Took examples of @Simon's post from GitHub and changed into JSFiddle and linked.
Comment 3 zalan 2023-07-04 07:25:33 PDT
This is pretty much about removing the following lines: (now that the spec is clear)
            clonedStyle.setDisplay(DisplayType::Inline);
            clonedStyle.setFloating(Float::None);
            clonedStyle.setPosition(PositionType::Static);
in TreeBuilder::createLayoutBox.

will fix it soon.
Comment 4 Ahmad Saleem 2023-07-29 06:37:34 PDT
(In reply to zalan from comment #3)
> This is pretty much about removing the following lines: (now that the spec
> is clear)
>             clonedStyle.setDisplay(DisplayType::Inline);
>             clonedStyle.setFloating(Float::None);
>             clonedStyle.setPosition(PositionType::Static);
> in TreeBuilder::createLayoutBox.
> 
> will fix it soon.

Deleting these three lines didn't fix it on local for me. :-(
Comment 5 zalan 2023-07-29 15:58:16 PDT
repurpose it for the float case. out-of-flow case is here 259631
Comment 6 zalan 2023-07-29 15:58:28 PDT
bug 259631
Comment 7 zalan 2023-07-29 16:02:26 PDT
(In reply to Ahmad Saleem from comment #4)
> (In reply to zalan from comment #3)
> > This is pretty much about removing the following lines: (now that the spec
> > is clear)
> >             clonedStyle.setDisplay(DisplayType::Inline);
> >             clonedStyle.setFloating(Float::None);
> >             clonedStyle.setPosition(PositionType::Static);
> > in TreeBuilder::createLayoutBox.
> > 
> > will fix it soon.
> 
> Deleting these three lines didn't fix it on local for me. :-(
yeah it's slightly more involved.