Bug 23003

Summary: [Canvas] Cairo needs arcTo
Product: WebKit Reporter: Dirk Schulze <krit>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
URL: http://canvex.lazyilluminati.com/misc/arcto.html
Attachments:
Description Flags
arcTo for PathCairo
none
Implementation drawing
none
arcTo for PathCairo oliver: review+

Dirk Schulze
Reported 2008-12-27 08:06:46 PST
Cario needs arcTo support for canvas.
Attachments
arcTo for PathCairo (4.43 KB, patch)
2008-12-27 08:21 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Implementation drawing (15.17 KB, image/svg+xml)
2008-12-27 08:24 PST, Dirk Schulze 		no flags
Details
arcTo for PathCairo (4.49 KB, patch)
2008-12-29 06:55 PST, Dirk Schulze 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2008-12-27 08:21:48 PST
Created attachment 26266 [details] arcTo for PathCairo This implementation is based on vector analysis. I'll add a graphic, to help understanding the patch.
Dirk Schulze
Comment 2 2008-12-27 08:24:39 PST
Created attachment 26267 [details] Implementation drawing I hope this SVG helps the reviewer to understand the patch.
Dirk Schulze
Comment 3 2008-12-29 06:55:38 PST
Created attachment 26292 [details] arcTo for PathCairo forgot a check if ea should be more or less than pi.
Oliver Hunt
Comment 4 2008-12-29 23:25:52 PST
Comment on attachment 26292 [details] arcTo for PathCairo r=me
Dirk Schulze
Comment 5 2008-12-29 23:37:41 PST
landed in r39511.
Note You need to log in before you can comment on or make changes to this bug.