Bug 230022

Summary: Remove unneeded call on startup of WebContent process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch none

Description Per Arne Vollan 2021-09-07 13:54:52 PDT
There is no need to call CGSShutdownServerConnections during startup of the WebContent process on macOS, since we already have asserted that there are no open connections at this point.
Comment 1 Radar WebKit Bug Importer 2021-09-07 13:55:32 PDT
<rdar://problem/82838000>
Comment 2 Per Arne Vollan 2021-09-07 14:01:46 PDT
Created attachment 437554 [details]
Patch
Comment 3 Darin Adler 2021-09-07 14:07:24 PDT
Comment on attachment 437554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437554&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636
> -    // Make sure that we close any WindowServer connections after checking in with Launch Services.
> -    CGSShutdownServerConnections();

Can we also take this out of CoreGraphicsSPI.h?
Comment 4 Per Arne Vollan 2021-09-07 14:10:29 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 437554 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437554&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636
> > -    // Make sure that we close any WindowServer connections after checking in with Launch Services.
> > -    CGSShutdownServerConnections();
> 
> Can we also take this out of CoreGraphicsSPI.h?

Yes, that's a good point, will fix.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-09-07 15:34:44 PDT
Created attachment 437564 [details]
Patch
Comment 6 EWS 2021-09-08 10:31:04 PDT
Committed r282157 (241449@main): <https://commits.webkit.org/241449@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437564 [details].