Bug 229944

Summary: Use event queue to fire RTCPeerConnection events
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2021-09-06 02:17:31 PDT
Use event queue to fire RTCPeerConnection events
Comment 1 youenn fablet 2021-09-06 02:20:22 PDT
Created attachment 437399 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-13 02:18:16 PDT
<rdar://problem/83045723>
Comment 3 youenn fablet 2021-09-14 03:18:10 PDT
Created attachment 438119 [details]
Patch
Comment 4 youenn fablet 2021-09-14 07:55:27 PDT
Created attachment 438142 [details]
Patch
Comment 5 Eric Carlson 2021-09-14 08:36:46 PDT
Comment on attachment 438142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438142&action=review

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:235
> +            m_peerConnection.dispatchEvent(RTCTrackEvent::create(eventNames().trackEvent, Event::CanBubble::No, Event::IsCancelable::No, WTFMove(event.receiver), WTFMove(event.track), WTFMove(event.streams), WTFMove(event.transceiver)));

Why are some events dispatched synchronously instead of on the task queue?
Comment 6 youenn fablet 2021-09-15 01:15:02 PDT
Created attachment 438222 [details]
Patch for landing
Comment 7 EWS 2021-09-15 02:11:57 PDT
Committed r282445 (241698@main): <https://commits.webkit.org/241698@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438222 [details].