Bug 22992

Summary:

Javascript console should not attempt to scroll to end of console if console is not visible

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, commit-queue, pfeldman, rik, timothy

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed solution	none

Oliver Hunt

Reported 2008-12-25 02:17:23 PST

* SUMMARY Whenever a message is sent to the console the web inspector attempts to scroll the appropriate portion of the console to be visible. Unfortunately if the console is not visible, this is very heavy wait operation as it requires building the rendertree, calculating where it should scroll to, then throwing the rendertree away. * STEPS TO REPRODUCE 1. use javascript along the lines of javascript:while(1) console.log("foo") * RESULTS Shark shows 94% of time being spent in style recalc. <rdar://problem/6467200>

Attachments
[PATCH] Proposed solution (1.88 KB, patch) 2010-02-25 08:21 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2010-02-25 08:14:27 PST

This scenario is also extremely slow when the console is visible. The scrollIntoView calls should be throttled.

Alexander Pavlov (apavlov)

Comment 2 2010-02-25 08:21:40 PST

Created attachment 49489 [details] [PATCH] Proposed solution

WebKit Commit Bot

Comment 3 2010-02-25 14:14:57 PST

Comment on attachment 49489 [details] [PATCH] Proposed solution Clearing flags on attachment: 49489 Committed r55255: <http://trac.webkit.org/changeset/55255>

WebKit Commit Bot

Comment 4 2010-02-25 14:15:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.