Bug 229897

Summary: Implement exp,log functions calc functions
Product: WebKit Reporter: Nikos Mouchtaris <nmouchtaris>
Component: New BugsAssignee: Nikos Mouchtaris <nmouchtaris>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, macpherson, menard, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
simon.fraser: review+
implement exp/log calc functions
none
Exp/log functions
ews-feeder: commit-queue-
exp/log functions none

Nikos Mouchtaris
Reported 2021-09-03 14:47:36 PDT
Implement exp,log functions calc functions
Attachments
Patch (13.96 KB, patch)
2021-09-03 14:48 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (20.91 KB, patch)
2021-09-14 17:02 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (27.51 KB, patch)
2021-09-15 12:44 PDT, Nikos Mouchtaris 		simon.fraser: review+
DetailsFormatted DiffDiff
implement exp/log calc functions (28.02 KB, patch)
2021-09-16 14:10 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Exp/log functions (30.17 KB, patch)
2021-09-17 13:42 PDT, Nikos Mouchtaris 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
exp/log functions (30.16 KB, patch)
2021-09-20 14:54 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikos Mouchtaris
Comment 1 2021-09-03 14:48:53 PDT
Created attachment 437316 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-09-07 13:46:39 PDT
<rdar://problem/82837516>
Nikos Mouchtaris
Comment 3 2021-09-14 17:02:28 PDT
Created attachment 438191 [details] Patch
EWS Watchlist
Comment 4 2021-09-14 17:03:42 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Nikos Mouchtaris
Comment 5 2021-09-15 12:44:48 PDT
Created attachment 438280 [details] Patch
Simon Fraser (smfr)
Comment 6 2021-09-15 16:53:00 PDT
Comment on attachment 438280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438280&action=review > Source/WebCore/ChangeLog:7 > + Reviewed by NOBODY (OOPS!). > + You should write some words here about the change. > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:-441 > - return; Is this removal significant? The changelog does not mention it.
Simon Fraser (smfr)
Comment 7 2021-09-15 16:59:55 PDT
Comment on attachment 438280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438280&action=review > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:478 > + Remove this blank line.
Nikos Mouchtaris
Comment 8 2021-09-16 14:10:40 PDT
Created attachment 438400 [details] implement exp/log calc functions
Nikos Mouchtaris
Comment 9 2021-09-17 13:42:20 PDT
Created attachment 438508 [details] Exp/log functions
EWS
Comment 10 2021-09-20 14:48:09 PDT
ChangeLog entry in LayoutTests/imported/w3c/ChangeLog contains OOPS!.
Nikos Mouchtaris
Comment 11 2021-09-20 14:54:41 PDT
Created attachment 438735 [details] exp/log functions
EWS
Comment 12 2021-09-20 17:24:58 PDT
Committed r282795 (241929@main): <https://commits.webkit.org/241929@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438735 [details].
Note You need to log in before you can comment on or make changes to this bug.